forked from jappel/leistungsbilanz-ts
Julian Appel
b45dc5002d
Full-codebase review turned up five real correctness/security bugs and
a dozen smaller inconsistencies; all are fixed here with matching test
coverage:
- BMK uniqueness silently allowed German-umlaut duplicates ("Ä1" vs
"ä1") because the DB's normalized index only folds ASCII case. Added
a shared Unicode-aware pre-check used by every circuit/component
insert and rename path (one of which had no pre-check at all).
- CircuitDeviceRow.simultaneityFactor had no upper bound at the row
level (command model and snapshot/restore schema), unlike every
sibling entity, letting a bad value silently corrupt power totals.
- Grid cell editing silently misread German thousands-separator input
("1.500" parsed as 1.5); "." is now rejected outright with a clear
message instead of guessing.
- The editor's shared command runner (runCommand/applyHistory) had no
re-entrancy guard, so a double click/drop could fire the same
command twice and race a BMK collision or revision conflict. Added a
synchronous ref guard plus isSaving on the buttons that lacked it.
- GET .../next-identifier leaked circuit-numbering state for sections
in other projects (no ownership check, 400 instead of 404). Moved
under /projects/:projectId and scoped it.
Also: added the missing circuits.section_id / circuit_device_rows.
circuit_id indexes (migration 0006), gave FormModal a focus trap /
Escape-to-close / focus restore and rebuilt ProjectSettingsModal on
top of it instead of duplicated markup, removed dead code (3 orphaned
domain model files, an unused persistence helper, a wrapper only used
by its own test), pointed the project page at GET /projects/:id
instead of listing+filtering client-side, closed the gap between the
documented 18 MB CSV limit and the ~17.17 MiB actually enforced, added
missing upper bounds on several free-text fields, filled in nine
missing German labels in the revision timeline, replaced a
key-order-fragile JSON.stringify equality check with a real field
comparison, made an implicit sort-order assumption in three
renumbering helpers explicit, cleared the sidebar's target selection
when it no longer resolves after a tree reload, and fixed
updateGlobalDevice to check-then-write instead of write-then-check.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| fixtures | ||
| support | ||
| circuit-device-row-move-command.test.ts | ||
| circuit-device-row-move-project-command.repository.test.ts | ||
| circuit-device-row-project-command.repository.test.ts | ||
| circuit-device-row-quantity.test.ts | ||
| circuit-device-row-structure-project-command.repository.test.ts | ||
| circuit-editor-history.test.ts | ||
| circuit-grid-insertion.test.ts | ||
| circuit-grid-model.test.ts | ||
| circuit-grid-projection.test.ts | ||
| circuit-grid-safety.test.ts | ||
| circuit-group-move-project-command.repository.test.ts | ||
| circuit-group-numbering.test.ts | ||
| circuit-group-renumber-project-command.repository.test.ts | ||
| circuit-group-structure-project-command.repository.test.ts | ||
| circuit-group-subtree-project-command.repository.test.ts | ||
| circuit-group-subtree-snapshot.test.ts | ||
| circuit-numbering.service.test.ts | ||
| circuit-power-calculation.test.ts | ||
| circuit-project-command.repository.test.ts | ||
| circuit-protection-project-command.repository.test.ts | ||
| circuit-section-renumber-command.test.ts | ||
| circuit-section-renumber-project-command.repository.test.ts | ||
| circuit-section-reorder-command.test.ts | ||
| circuit-section-reorder-project-command.repository.test.ts | ||
| circuit-structure-command.test.ts | ||
| circuit-structure-project-command.repository.test.ts | ||
| circuit-structure-projection.test.ts | ||
| circuit-tree.controller.test.ts | ||
| circuit.controller.test.ts | ||
| database-backup.test.ts | ||
| distribution-board-component-structure-project-command.repository.test.ts | ||
| distribution-board-component.test.ts | ||
| distribution-board-structure-project-command.repository.test.ts | ||
| distribution-board-subtree-project-command.repository.test.ts | ||
| distribution-board-subtree.test.ts | ||
| external-circuit-list-objects.test.ts | ||
| external-csv-api-contract.test.ts | ||
| external-csv-configuration-project-command.repository.test.ts | ||
| external-csv-configuration.test.ts | ||
| external-csv-preview.test.ts | ||
| external-csv-transport.test.ts | ||
| external-initial-import-plan.test.ts | ||
| external-initial-import-project-command.repository.test.ts | ||
| external-model-foundation.test.ts | ||
| external-object-row-assignment-project-command.repository.test.ts | ||
| logger.test.ts | ||
| project-command.model.test.ts | ||
| project-command.service.test.ts | ||
| project-device-placement.service.test.ts | ||
| project-device-project-command.repository.test.ts | ||
| project-device-row-sync-project-command.repository.test.ts | ||
| project-device-schema.test.ts | ||
| project-device-structure-project-command.repository.test.ts | ||
| project-device-sync.service.test.ts | ||
| project-history-timeline.test.ts | ||
| project-history.repository.test.ts | ||
| project-location-structure-project-command.repository.test.ts | ||
| project-overview-import.test.ts | ||
| project-revision.persistence.test.ts | ||
| project-settings-project-command.repository.test.ts | ||
| project-snapshot-policy.test.ts | ||
| project-snapshot.repository.test.ts | ||
| project-state-restore-command.repository.test.ts | ||
| project-state-snapshot.test.ts | ||
| project-version-history.test.ts | ||
| protection-device.test.ts | ||
| revit-csv-frontend-api.test.ts | ||