Isolate device row transactions

This commit is contained in:
2026-07-23 18:33:22 +02:00
parent d7fda37576
commit 30c7555c68
15 changed files with 458 additions and 352 deletions
+9 -162
View File
@@ -125,7 +125,9 @@ describe("circuit write service rules", () => {
async findById() {
return { id: "r1", circuitId: "c1" } as never;
},
deleteFromCircuitTransactional(rowId: string, circuitId: string) {
} as never,
deviceRowTransactionStore: {
deleteFromCircuit(rowId: string, circuitId: string) {
transactionalDelete = { rowId, circuitId };
},
} as never,
@@ -170,14 +172,16 @@ describe("circuit write service rules", () => {
},
} as never,
deviceRowRepository: {
createInCircuitTransactional(input: typeof transactionalCreate) {
transactionalCreate = input;
return "row1";
},
async findById() {
return { id: "row1" } as never;
},
} as never,
deviceRowTransactionStore: {
createInCircuit(input: typeof transactionalCreate) {
transactionalCreate = input;
return "row1";
},
} as never,
circuitListRepository: {} as never,
circuitSectionRepository: {} as never,
projectDeviceRepository: {
@@ -921,163 +925,6 @@ describe("circuit write service rules", () => {
}
});
it("device row creation and reserve activation share one synchronous transaction", () => {
const repository = new CircuitDeviceRowRepository();
const originalTransaction = (db as unknown as { transaction: unknown }).transaction;
let callbackReturnedPromise = false;
let insertedValues: { id?: string; circuitId?: string; sortOrder?: number } | undefined;
let reserveValue: number | undefined;
let selectCall = 0;
(db as unknown as { transaction: (cb: (tx: unknown) => unknown) => void }).transaction = (cb) => {
const fakeTx = {
select() {
const rows = selectCall++ === 0 ? [{ id: "c1" }] : [{ sortOrder: 20 }];
const query = {
from() {
return query;
},
where() {
return query;
},
limit() {
return query;
},
all() {
return rows;
},
};
return query;
},
insert() {
return {
values(values: typeof insertedValues) {
insertedValues = values;
return {
run() {
return { changes: 1 };
},
};
},
};
},
update() {
return {
set(values: { isReserve: number }) {
reserveValue = values.isReserve;
return {
where() {
return {
run() {
return { changes: 1 };
},
};
},
};
},
};
},
};
const callbackResult = cb(fakeTx);
callbackReturnedPromise = Boolean(
callbackResult && typeof (callbackResult as Promise<unknown>).then === "function"
);
};
try {
const rowId = repository.createInCircuitTransactional({
circuitId: "c1",
name: "Load",
displayName: "Load",
quantity: 1,
powerPerUnit: 1,
simultaneityFactor: 1,
});
assert.equal(callbackReturnedPromise, false);
assert.equal(insertedValues?.id, rowId);
assert.equal(insertedValues?.circuitId, "c1");
assert.equal(insertedValues?.sortOrder, 30);
assert.equal(reserveValue, 0);
} finally {
(db as unknown as { transaction: unknown }).transaction = originalTransaction;
}
});
it("device row deletion and reserve update share one synchronous transaction", () => {
const repository = new CircuitDeviceRowRepository();
const originalTransaction = (db as unknown as { transaction: unknown }).transaction;
let callbackReturnedPromise = false;
let deleteCount = 0;
let reserveValue: number | undefined;
let selectCall = 0;
(db as unknown as { transaction: (cb: (tx: unknown) => unknown) => void }).transaction = (cb) => {
const fakeTx = {
select() {
const rows = selectCall++ === 0 ? [{ id: "r1", circuitId: "c1" }] : [];
const query = {
from() {
return query;
},
where() {
return query;
},
limit() {
return query;
},
all() {
return rows;
},
};
return query;
},
delete() {
return {
where() {
return {
run() {
deleteCount += 1;
return { changes: 1 };
},
};
},
};
},
update() {
return {
set(values: { isReserve: number }) {
reserveValue = values.isReserve;
return {
where() {
return {
run() {
return { changes: 1 };
},
};
},
};
},
};
},
};
const callbackResult = cb(fakeTx);
callbackReturnedPromise = Boolean(
callbackResult && typeof (callbackResult as Promise<unknown>).then === "function"
);
};
try {
repository.deleteFromCircuitTransactional("r1", "c1");
assert.equal(callbackReturnedPromise, false);
assert.equal(deleteCount, 1);
assert.equal(reserveValue, 1);
} finally {
(db as unknown as { transaction: unknown }).transaction = originalTransaction;
}
});
it("new circuit and initial device rows share one synchronous transaction", () => {
const repository = new CircuitDeviceRowRepository();
const originalTransaction = (db as unknown as { transaction: unknown }).transaction;