Make circuit reordering atomic

2026-07-23 17:30:40 +02:00
parent 7d276d1139
commit b0fc2b4fbf
4 changed files with 105 additions and 34 deletions
@@ -476,32 +476,7 @@ export class CircuitWriteService {
      }
    }

-    for (let index = 0; index < input.orderedCircuitIds.length; index += 1) {
-      const circuitId = input.orderedCircuitIds[index];
-      const circuit = sectionCircuits.find((entry) => entry.id === circuitId);
-      if (!circuit) {
-        throw new Error("Invalid circuit id.");
-      }
-      await this.circuitRepository.update(circuit.id, {
-        sectionId: circuit.sectionId,
-        equipmentIdentifier: circuit.equipmentIdentifier,
-        displayName: circuit.displayName ?? undefined,
-        sortOrder: (index + 1) * 10,
-        protectionType: circuit.protectionType ?? undefined,
-        protectionRatedCurrent: circuit.protectionRatedCurrent ?? undefined,
-        protectionCharacteristic: circuit.protectionCharacteristic ?? undefined,
-        cableType: circuit.cableType ?? undefined,
-        cableCrossSection: circuit.cableCrossSection ?? undefined,
-        cableLength: circuit.cableLength ?? undefined,
-        rcdAssignment: circuit.rcdAssignment ?? undefined,
-        terminalDesignation: circuit.terminalDesignation ?? undefined,
-        voltage: circuit.voltage ?? undefined,
-        controlRequirement: circuit.controlRequirement ?? undefined,
-        status: circuit.status ?? undefined,
-        isReserve: Boolean(circuit.isReserve),
-        remark: circuit.remark ?? undefined,
-      });
-    }
+    this.circuitRepository.updateSortOrdersSafely(sectionId, input.orderedCircuitIds);
    return this.circuitRepository.listBySection(sectionId);
  }
 }