Julian Appel
b45dc5002d
Full-codebase review turned up five real correctness/security bugs and
a dozen smaller inconsistencies; all are fixed here with matching test
coverage:
- BMK uniqueness silently allowed German-umlaut duplicates ("Ä1" vs
"ä1") because the DB's normalized index only folds ASCII case. Added
a shared Unicode-aware pre-check used by every circuit/component
insert and rename path (one of which had no pre-check at all).
- CircuitDeviceRow.simultaneityFactor had no upper bound at the row
level (command model and snapshot/restore schema), unlike every
sibling entity, letting a bad value silently corrupt power totals.
- Grid cell editing silently misread German thousands-separator input
("1.500" parsed as 1.5); "." is now rejected outright with a clear
message instead of guessing.
- The editor's shared command runner (runCommand/applyHistory) had no
re-entrancy guard, so a double click/drop could fire the same
command twice and race a BMK collision or revision conflict. Added a
synchronous ref guard plus isSaving on the buttons that lacked it.
- GET .../next-identifier leaked circuit-numbering state for sections
in other projects (no ownership check, 400 instead of 404). Moved
under /projects/:projectId and scoped it.
Also: added the missing circuits.section_id / circuit_device_rows.
circuit_id indexes (migration 0006), gave FormModal a focus trap /
Escape-to-close / focus restore and rebuilt ProjectSettingsModal on
top of it instead of duplicated markup, removed dead code (3 orphaned
domain model files, an unused persistence helper, a wrapper only used
by its own test), pointed the project page at GET /projects/:id
instead of listing+filtering client-side, closed the gap between the
documented 18 MB CSV limit and the ~17.17 MiB actually enforced, added
missing upper bounds on several free-text fields, filled in nine
missing German labels in the revision timeline, replaced a
key-order-fragile JSON.stringify equality check with a real field
comparison, made an implicit sort-order assumption in three
renumbering helpers explicit, cleared the sidebar's target selection
when it no longer resolves after a tree reload, and fixed
updateGlobalDevice to check-then-write instead of write-then-check.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
101 lines
3.7 KiB
TypeScript
101 lines
3.7 KiB
TypeScript
import { circuitDeviceRows } from "../schema/circuit-device-rows.js";
|
|
|
|
export interface CircuitDeviceRowUpdateInput {
|
|
linkedProjectDeviceId?: string;
|
|
name: string;
|
|
displayName: string;
|
|
phaseType?: string;
|
|
connectionKind?: string;
|
|
costGroup?: string;
|
|
category?: string;
|
|
level?: string;
|
|
roomId?: string;
|
|
roomNumberSnapshot?: string;
|
|
roomNameSnapshot?: string;
|
|
quantity: number;
|
|
manualQuantity?: number;
|
|
powerPerUnit: number;
|
|
simultaneityFactor: number;
|
|
cosPhi?: number;
|
|
remark?: string;
|
|
overriddenFields?: string;
|
|
}
|
|
|
|
export interface CircuitDeviceRowPatchInput {
|
|
linkedProjectDeviceId?: string | null;
|
|
sortOrder?: number;
|
|
name?: string;
|
|
displayName?: string;
|
|
phaseType?: string | null;
|
|
connectionKind?: string | null;
|
|
costGroup?: string | null;
|
|
category?: string | null;
|
|
level?: string | null;
|
|
roomId?: string | null;
|
|
roomNumberSnapshot?: string | null;
|
|
roomNameSnapshot?: string | null;
|
|
quantity?: number;
|
|
manualQuantity?: number;
|
|
powerPerUnit?: number;
|
|
simultaneityFactor?: number;
|
|
cosPhi?: number | null;
|
|
remark?: string | null;
|
|
overriddenFields?: string | null;
|
|
}
|
|
|
|
export function toCircuitDeviceRowUpdateValues(input: CircuitDeviceRowUpdateInput) {
|
|
return {
|
|
linkedProjectDeviceId: input.linkedProjectDeviceId ?? null,
|
|
name: input.name,
|
|
displayName: input.displayName,
|
|
phaseType: input.phaseType ?? null,
|
|
connectionKind: input.connectionKind ?? null,
|
|
costGroup: input.costGroup ?? null,
|
|
category: input.category ?? null,
|
|
level: input.level ?? null,
|
|
roomId: input.roomId ?? null,
|
|
roomNumberSnapshot: input.roomNumberSnapshot ?? null,
|
|
roomNameSnapshot: input.roomNameSnapshot ?? null,
|
|
quantity: input.quantity,
|
|
manualQuantity: input.manualQuantity ?? input.quantity,
|
|
powerPerUnit: input.powerPerUnit,
|
|
simultaneityFactor: input.simultaneityFactor,
|
|
cosPhi: input.cosPhi ?? null,
|
|
remark: input.remark ?? null,
|
|
overriddenFields: input.overriddenFields ?? null,
|
|
};
|
|
}
|
|
|
|
export function toCircuitDeviceRowPatchValues(input: CircuitDeviceRowPatchInput) {
|
|
const values: Partial<typeof circuitDeviceRows.$inferInsert> = {};
|
|
const has = (field: keyof CircuitDeviceRowPatchInput) =>
|
|
Object.prototype.hasOwnProperty.call(input, field);
|
|
|
|
if (has("linkedProjectDeviceId")) {
|
|
values.linkedProjectDeviceId = input.linkedProjectDeviceId ?? null;
|
|
}
|
|
if (input.name !== undefined) values.name = input.name;
|
|
if (input.displayName !== undefined) values.displayName = input.displayName;
|
|
if (has("phaseType")) values.phaseType = input.phaseType ?? null;
|
|
if (has("connectionKind")) values.connectionKind = input.connectionKind ?? null;
|
|
if (has("costGroup")) values.costGroup = input.costGroup ?? null;
|
|
if (has("category")) values.category = input.category ?? null;
|
|
if (has("level")) values.level = input.level ?? null;
|
|
if (has("roomId")) values.roomId = input.roomId ?? null;
|
|
if (has("roomNumberSnapshot")) {
|
|
values.roomNumberSnapshot = input.roomNumberSnapshot ?? null;
|
|
}
|
|
if (has("roomNameSnapshot")) values.roomNameSnapshot = input.roomNameSnapshot ?? null;
|
|
if (input.quantity !== undefined) values.quantity = input.quantity;
|
|
if (input.manualQuantity !== undefined) values.manualQuantity = input.manualQuantity;
|
|
if (input.powerPerUnit !== undefined) values.powerPerUnit = input.powerPerUnit;
|
|
if (input.simultaneityFactor !== undefined) {
|
|
values.simultaneityFactor = input.simultaneityFactor;
|
|
}
|
|
if (has("cosPhi")) values.cosPhi = input.cosPhi ?? null;
|
|
if (has("remark")) values.remark = input.remark ?? null;
|
|
if (has("overriddenFields")) values.overriddenFields = input.overriddenFields ?? null;
|
|
if (input.sortOrder !== undefined) values.sortOrder = input.sortOrder;
|
|
|
|
return values;
|
|
}
|