Full-codebase review turned up five real correctness/security bugs and
a dozen smaller inconsistencies; all are fixed here with matching test
coverage:
- BMK uniqueness silently allowed German-umlaut duplicates ("Ä1" vs
"ä1") because the DB's normalized index only folds ASCII case. Added
a shared Unicode-aware pre-check used by every circuit/component
insert and rename path (one of which had no pre-check at all).
- CircuitDeviceRow.simultaneityFactor had no upper bound at the row
level (command model and snapshot/restore schema), unlike every
sibling entity, letting a bad value silently corrupt power totals.
- Grid cell editing silently misread German thousands-separator input
("1.500" parsed as 1.5); "." is now rejected outright with a clear
message instead of guessing.
- The editor's shared command runner (runCommand/applyHistory) had no
re-entrancy guard, so a double click/drop could fire the same
command twice and race a BMK collision or revision conflict. Added a
synchronous ref guard plus isSaving on the buttons that lacked it.
- GET .../next-identifier leaked circuit-numbering state for sections
in other projects (no ownership check, 400 instead of 404). Moved
under /projects/:projectId and scoped it.
Also: added the missing circuits.section_id / circuit_device_rows.
circuit_id indexes (migration 0006), gave FormModal a focus trap /
Escape-to-close / focus restore and rebuilt ProjectSettingsModal on
top of it instead of duplicated markup, removed dead code (3 orphaned
domain model files, an unused persistence helper, a wrapper only used
by its own test), pointed the project page at GET /projects/:id
instead of listing+filtering client-side, closed the gap between the
documented 18 MB CSV limit and the ~17.17 MiB actually enforced, added
missing upper bounds on several free-text fields, filled in nine
missing German labels in the revision timeline, replaced a
key-order-fragile JSON.stringify equality check with a real field
comparison, made an implicit sort-order assumption in three
renumbering helpers explicit, cleared the sidebar's target selection
when it no longer resolves after a tree reload, and fixed
updateGlobalDevice to check-then-write instead of write-then-check.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
132 lines
4.9 KiB
TypeScript
132 lines
4.9 KiB
TypeScript
import type {
|
|
ProjectRevisionSourceDto,
|
|
ProjectRevisionSummaryDto,
|
|
ProjectSnapshotMetadataDto,
|
|
} from "../types";
|
|
|
|
const sourceLabels: Record<ProjectRevisionSourceDto, string> = {
|
|
user: "Bearbeitung",
|
|
undo: "Rückgängig",
|
|
redo: "Wiederholt",
|
|
restore: "Wiederherstellung",
|
|
migration: "Migration",
|
|
};
|
|
|
|
const commandTypeLabels: Record<string, string> = {
|
|
"circuit.update": "Stromkreis bearbeitet",
|
|
"circuit.insert": "Stromkreis angelegt",
|
|
"circuit.delete": "Stromkreis gelöscht",
|
|
"circuit-device-row.update": "Gerätezeile bearbeitet",
|
|
"circuit-device-row.insert": "Gerätezeile angelegt",
|
|
"circuit-device-row.delete": "Gerätezeile gelöscht",
|
|
"circuit-device-row.move": "Gerätezeile verschoben",
|
|
"circuit-device-row.move-with-new-circuit":
|
|
"Gerätezeile in neuen Stromkreis verschoben",
|
|
"circuit.reorder-section": "Stromkreise sortiert",
|
|
"circuit.reorder-sections": "Stromkreise bereichsübergreifend sortiert",
|
|
"circuit.renumber-section": "Bereich neu nummeriert",
|
|
"project-device.update": "Projektgerät bearbeitet",
|
|
"project-device.insert": "Projektgerät angelegt",
|
|
"project-device.delete": "Projektgerät gelöscht",
|
|
"project-device.sync-rows": "Projektgerät-Verknüpfungen geändert",
|
|
"project.update-settings": "Projekteinstellungen bearbeitet",
|
|
"distribution-board.insert": "Verteilung angelegt",
|
|
"distribution-board.update": "Verteilung bearbeitet",
|
|
"distribution-board.delete": "Verteilung entfernt",
|
|
"distribution-board.insert-subtree": "Verteilung vollständig eingefügt",
|
|
"distribution-board.delete-subtree": "Verteilung vollständig entfernt",
|
|
"distribution-board-component.insert": "Verteilergerät angelegt",
|
|
"distribution-board-component.delete": "Verteilergerät entfernt",
|
|
"distribution-board-component.update": "Verteilergerät bearbeitet",
|
|
"circuit-group.insert": "Stromkreisgruppe angelegt",
|
|
"circuit-group.delete": "Stromkreisgruppe entfernt",
|
|
"circuit-group.update": "Stromkreisgruppe bearbeitet",
|
|
"circuit-group.reorder": "Stromkreisgruppen sortiert",
|
|
"circuit-group.renumber": "Stromkreisgruppen neu nummeriert",
|
|
"circuit.move-group": "Stromkreis in andere Gruppe verschoben",
|
|
"circuit-group.delete-subtree": "Stromkreisgruppe vollständig entfernt",
|
|
"circuit-group.restore-subtree": "Stromkreisgruppe vollständig wiederhergestellt",
|
|
"project-floor.insert": "Geschoss angelegt",
|
|
"project-floor.update": "Geschoss bearbeitet",
|
|
"project-floor.delete": "Geschoss entfernt",
|
|
"project-room.insert": "Raum angelegt",
|
|
"project-room.update": "Raum bearbeitet",
|
|
"project-room.delete": "Raum entfernt",
|
|
"project.restore-state": "Projektstand wiederhergestellt",
|
|
"circuit-protection.update": "Stromkreisschutz bearbeitet",
|
|
"external-csv-configuration.update": "Revit-CSV-Konfiguration bearbeitet",
|
|
"external-import.apply-initial": "Revit-Erstimport übernommen",
|
|
"external-object.assign-to-new-circuit":
|
|
"Externes Objekt in neuen Stromkreis übernommen",
|
|
"external-object.unassign-and-delete-created-circuit":
|
|
"Externes Objekt aus erzeugtem Stromkreis gelöst",
|
|
"external-object.assign-to-new-row":
|
|
"Externes Objekt in neue Gerätezeile übernommen",
|
|
"external-object.unassign-and-delete-created-row":
|
|
"Externes Objekt aus erzeugter Gerätezeile gelöst",
|
|
"external-object.update-row-assignment": "Externe Objektzuordnung geändert",
|
|
};
|
|
|
|
export function getProjectRevisionSourceLabel(
|
|
source: ProjectRevisionSourceDto
|
|
) {
|
|
return sourceLabels[source];
|
|
}
|
|
|
|
export function getProjectRevisionDescription(
|
|
revision: ProjectRevisionSummaryDto
|
|
) {
|
|
const description = revision.description?.trim();
|
|
if (
|
|
description === `Undo ${revision.commandType}` ||
|
|
description === `Redo ${revision.commandType}`
|
|
) {
|
|
return commandTypeLabels[revision.commandType] || revision.commandType;
|
|
}
|
|
return (
|
|
description ||
|
|
commandTypeLabels[revision.commandType] ||
|
|
revision.commandType
|
|
);
|
|
}
|
|
|
|
export function getProjectSnapshotKindLabel(
|
|
kind: ProjectSnapshotMetadataDto["kind"]
|
|
) {
|
|
return kind === "automatic" ? "Automatisch" : "Benannt";
|
|
}
|
|
|
|
export function getProjectSnapshotRevisionDescription(
|
|
snapshot: ProjectSnapshotMetadataDto
|
|
) {
|
|
if (snapshot.sourceRevision === 0) {
|
|
return "Projektstart";
|
|
}
|
|
if (
|
|
!snapshot.sourceRevisionMetadata ||
|
|
snapshot.sourceRevisionMetadata.revisionNumber !==
|
|
snapshot.sourceRevision
|
|
) {
|
|
return "Änderungsdetails nicht verfügbar";
|
|
}
|
|
return `${getProjectRevisionSourceLabel(
|
|
snapshot.sourceRevisionMetadata.source
|
|
)}: ${getProjectRevisionDescription(
|
|
snapshot.sourceRevisionMetadata
|
|
)}`;
|
|
}
|
|
|
|
export function mergeProjectRevisionPages(
|
|
current: ProjectRevisionSummaryDto[],
|
|
next: ProjectRevisionSummaryDto[]
|
|
) {
|
|
const byId = new Map(
|
|
[...current, ...next].map((revision) => [
|
|
revision.revisionId,
|
|
revision,
|
|
])
|
|
);
|
|
return [...byId.values()].sort(
|
|
(left, right) => right.revisionNumber - left.revisionNumber
|
|
);
|
|
}
|