Julian Appel
b45dc5002d
Full-codebase review turned up five real correctness/security bugs and
a dozen smaller inconsistencies; all are fixed here with matching test
coverage:
- BMK uniqueness silently allowed German-umlaut duplicates ("Ä1" vs
"ä1") because the DB's normalized index only folds ASCII case. Added
a shared Unicode-aware pre-check used by every circuit/component
insert and rename path (one of which had no pre-check at all).
- CircuitDeviceRow.simultaneityFactor had no upper bound at the row
level (command model and snapshot/restore schema), unlike every
sibling entity, letting a bad value silently corrupt power totals.
- Grid cell editing silently misread German thousands-separator input
("1.500" parsed as 1.5); "." is now rejected outright with a clear
message instead of guessing.
- The editor's shared command runner (runCommand/applyHistory) had no
re-entrancy guard, so a double click/drop could fire the same
command twice and race a BMK collision or revision conflict. Added a
synchronous ref guard plus isSaving on the buttons that lacked it.
- GET .../next-identifier leaked circuit-numbering state for sections
in other projects (no ownership check, 400 instead of 404). Moved
under /projects/:projectId and scoped it.
Also: added the missing circuits.section_id / circuit_device_rows.
circuit_id indexes (migration 0006), gave FormModal a focus trap /
Escape-to-close / focus restore and rebuilt ProjectSettingsModal on
top of it instead of duplicated markup, removed dead code (3 orphaned
domain model files, an unused persistence helper, a wrapper only used
by its own test), pointed the project page at GET /projects/:id
instead of listing+filtering client-side, closed the gap between the
documented 18 MB CSV limit and the ~17.17 MiB actually enforced, added
missing upper bounds on several free-text fields, filled in nine
missing German labels in the revision timeline, replaced a
key-order-fragile JSON.stringify equality check with a real field
comparison, made an implicit sort-order assumption in three
renumbering helpers explicit, cleared the sidebar's target selection
when it no longer resolves after a tree reload, and fixed
updateGlobalDevice to check-then-write instead of write-then-check.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
110 lines
4.3 KiB
TypeScript
110 lines
4.3 KiB
TypeScript
import { Router } from "express";
|
|
import {
|
|
createProject,
|
|
getProject,
|
|
listProjects,
|
|
updateProjectSettings,
|
|
} from "../controllers/project.controller.js";
|
|
import {
|
|
copyDistributionBoard,
|
|
createDistributionBoard,
|
|
deleteDistributionBoard,
|
|
listDistributionBoardsByProject,
|
|
updateDistributionBoard,
|
|
} from "../controllers/distribution-board.controller.js";
|
|
import { listCircuitListsByProject } from "../controllers/circuit-list.controller.js";
|
|
import { createFloor, deleteFloor, listFloorsByProject, updateFloor } from "../controllers/floor.controller.js";
|
|
import { createRoom, deleteRoom, listRoomsByProject, updateRoom } from "../controllers/room.controller.js";
|
|
import { getCircuitTree } from "../controllers/circuit-tree.controller.js";
|
|
import { getNextCircuitIdentifier } from "../controllers/circuit.controller.js";
|
|
import {
|
|
getProjectHistory,
|
|
listProjectRevisions,
|
|
} from "../controllers/project-history.controller.js";
|
|
import {
|
|
executeProjectCommand,
|
|
redoProjectCommand,
|
|
undoProjectCommand,
|
|
} from "../controllers/project-command.controller.js";
|
|
import {
|
|
createNamedProjectSnapshot,
|
|
listProjectSnapshots,
|
|
restoreProjectSnapshot,
|
|
} from "../controllers/project-snapshot.controller.js";
|
|
import {
|
|
exportProjectTransfer,
|
|
importProjectTransfer,
|
|
importProjectTransferAsNewProject,
|
|
} from "../controllers/project-transfer.controller.js";
|
|
import {
|
|
getExternalCsvConfiguration,
|
|
applyExternalInitialImport,
|
|
previewExternalCsv,
|
|
planExternalInitialImport,
|
|
updateExternalCsvConfiguration,
|
|
getExternalCircuitListObjects,
|
|
} from "../controllers/external-csv.controller.js";
|
|
|
|
export const projectRouter = Router();
|
|
|
|
projectRouter.get("/", listProjects);
|
|
projectRouter.post("/", createProject);
|
|
projectRouter.post("/import", importProjectTransferAsNewProject);
|
|
projectRouter.get("/:projectId", getProject);
|
|
projectRouter.get("/:projectId/export", exportProjectTransfer);
|
|
projectRouter.post("/:projectId/import", importProjectTransfer);
|
|
projectRouter.get("/:projectId/external-csv/configuration", getExternalCsvConfiguration);
|
|
projectRouter.put("/:projectId/external-csv/configuration", updateExternalCsvConfiguration);
|
|
projectRouter.post("/:projectId/external-csv/preview", previewExternalCsv);
|
|
projectRouter.post(
|
|
"/:projectId/external-csv/initial-import/plan",
|
|
planExternalInitialImport
|
|
);
|
|
projectRouter.get(
|
|
"/:projectId/circuit-lists/:circuitListId/external-objects",
|
|
getExternalCircuitListObjects
|
|
);
|
|
projectRouter.post(
|
|
"/:projectId/external-csv/initial-import/apply",
|
|
applyExternalInitialImport
|
|
);
|
|
projectRouter.get("/:projectId/history", getProjectHistory);
|
|
projectRouter.get("/:projectId/history/revisions", listProjectRevisions);
|
|
projectRouter.post("/:projectId/commands", executeProjectCommand);
|
|
projectRouter.post("/:projectId/history/undo", undoProjectCommand);
|
|
projectRouter.post("/:projectId/history/redo", redoProjectCommand);
|
|
projectRouter.get("/:projectId/snapshots", listProjectSnapshots);
|
|
projectRouter.post("/:projectId/snapshots", createNamedProjectSnapshot);
|
|
projectRouter.post(
|
|
"/:projectId/snapshots/:snapshotId/restore",
|
|
restoreProjectSnapshot
|
|
);
|
|
projectRouter.put("/:projectId", updateProjectSettings);
|
|
projectRouter.get("/:projectId/distribution-boards", listDistributionBoardsByProject);
|
|
projectRouter.post("/:projectId/distribution-boards", createDistributionBoard);
|
|
projectRouter.post(
|
|
"/:projectId/distribution-boards/:distributionBoardId/copy",
|
|
copyDistributionBoard
|
|
);
|
|
projectRouter.put(
|
|
"/:projectId/distribution-boards/:distributionBoardId",
|
|
updateDistributionBoard
|
|
);
|
|
projectRouter.delete(
|
|
"/:projectId/distribution-boards/:distributionBoardId",
|
|
deleteDistributionBoard
|
|
);
|
|
projectRouter.get("/:projectId/circuit-lists", listCircuitListsByProject);
|
|
projectRouter.get("/:projectId/circuit-lists/:circuitListId/tree", getCircuitTree);
|
|
projectRouter.get(
|
|
"/:projectId/circuit-sections/:sectionId/next-identifier",
|
|
getNextCircuitIdentifier
|
|
);
|
|
projectRouter.get("/:projectId/floors", listFloorsByProject);
|
|
projectRouter.post("/:projectId/floors", createFloor);
|
|
projectRouter.put("/:projectId/floors/:floorId", updateFloor);
|
|
projectRouter.delete("/:projectId/floors/:floorId", deleteFloor);
|
|
projectRouter.get("/:projectId/rooms", listRoomsByProject);
|
|
projectRouter.post("/:projectId/rooms", createRoom);
|
|
projectRouter.put("/:projectId/rooms/:roomId", updateRoom);
|
|
projectRouter.delete("/:projectId/rooms/:roomId", deleteRoom);
|